Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a feature which randomizes the wallpaper based on a user defined interval by creating a script for the user #70

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chrissolanilla
Copy link

Hello, this is my fork of Waypaper. I have implemented a new feature that enhances user customization by allowing the wallpaper to be randomized at user-defined intervals. This feature includes the following:

  • New Button: A button has been added to the main interface which, when clicked, opens a menu.
    
  • Interval Setting: The menu provides an option for users to input an interval in seconds, specifying how frequently the wallpaper should change.
    
  • Start/Stop Script: The menu also includes options to start or stop the script responsible for changing the wallpaper at the defined interval.
    
  • Script Execution: When the interval is set, a script is created and executed to handle the wallpaper changes at the specified frequency. The user can stop this script anytime using the menu.
    

This is my first time potentially contributing to an open-source project, so it would mean a lot if you could accept my pull request. I am happy to do any revisions or changes as needed. Thank you for considering my contribution.

@anufrievroman
Copy link
Owner

Hi, thank you for your contribution, and congratulations with your first PR :)
I'll check it and give you some feedback, maybe today or in a few days.

@anufrievroman
Copy link
Owner

Sorry, I still didn't have time to check it. But preliminary comment is that this will work only once, right? I mean, it will not continue after restarting the session? I mean, maybe we need to make a config entry auto_change_interval = 0 and if it's not zero, the script starts again when we do waypaper --restore.

@chrissolanilla
Copy link
Author

Thats a good catch. Currently, the gui app only creates and executes the bash script when you click the button/s. If you did a waypaper --restore from booting up your pc, it would not start the script. However, the script will continue to run once you click the button to do so and will stop if you click the button to do so.

Adding an attribute to the config entry could potentially make this possible. I will play around with a solution and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants