Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie consent box layout and functionality issues #3347

Closed
wants to merge 2 commits into from

Conversation

diyabot
Copy link

@diyabot diyabot commented Oct 13, 2024

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Fixes: #3313

Description

This pull request addresses issue #3313, which involves layout and functionality improvements for the cookie consent box.

Summary of Changes:
I resolved layout issues that caused the reject button to overflow the consent box.
To prevent text overflow, ensure proper alignment and spacing for the 'Accept' and 'Reject' buttons.
Implemented functionality to hide the cookie consent box upon user interaction with the close, accept, or reject buttons.
Utilized localStorage to remember the user's cookie consent choice and prevent the consent box from reappearing after making a decision.
Motivation:
These changes improve the user experience by providing clear options for cookie consent while ensuring the design remains intact and functional.

Dependencies:
No additional dependencies are required for this change, aside from the updated body-parser.

Type of PR

  • [x ] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots/videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
PR after
PR before

Checklist:

  • [ x] I have made this change from my own.
  • I have taken help from some online resources.
  • [x ] My code follows the style guidelines of this project.
  • [x ] I have performed a self-review of my own code.
  • [x ] I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [x ] My changes generate no new warnings.
  • [x ] I have tested the changes thoroughly before submitting this pull request.
  • [x ] I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 5:40am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit b10dc45
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/670b5d226d980200088020ba
😎 Deploy Preview https://deploy-preview-3347--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sailaja-adapa
Copy link
Collaborator

@diyabot resolve conflicts and remove it as draft if you are ready

@diyabot diyabot marked this pull request as ready for review October 13, 2024 13:11
@abhisek2004
Copy link
Contributor

Error not fixed

Screenshot 2024-10-13 204647

@sailaja-adapa
Copy link
Collaborator

k

your changes causing issue to website work with updated branch and create new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Cookie Privacy Box Pop-up Unresponsive
3 participants