Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allinged toggle button for dark mode #3427

Conversation

SATYAM0LUFFY
Copy link
Contributor

@SATYAM0LUFFY SATYAM0LUFFY commented Oct 14, 2024

Corrects the toggle button for dark mode's position which is currently outside the full width of frame

None

Fixes: #3423

Description

Type of PR

  • Bug fix

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]

OLD:
Screenshot (831)

AFTER CHANGES MADE :
Screenshot (833)

!!! ATTENTION
I have removed a large no . of Unnecessary css for the toggle button ( which was not working ) so the change might look big .

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:11am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit d546511
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/670cb60389cee20008340abf
😎 Deploy Preview https://deploy-preview-3427--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Nav bar is not correctly aligned the dark mode button is even outside of the window frame
1 participant