Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have improved the book exchange form #3609

Closed
wants to merge 2 commits into from

Conversation

Vivisteria11
Copy link
Contributor

@Vivisteria11 Vivisteria11 commented Oct 17, 2024

Related Issue

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
None

Screen.Recording.2024-10-17.1.mp4

Fixes: #2877

Description

I have improved the form Book exchange HUB ,it was a very simple form before but now I have included more details where users input the genre of the book ,the condition it is in ,they can also input a discount price of their choice and I have included a function which will predict the selling price of the book based on that in INR. Users need to input their name and email ,along with this an optional field where they can type any interesting information about the book they are selling to appeal to another Reader and also an image can be uploaded for more context. Finally they can submit their form.

Type of PR

  • Feature enhancement -I have improved the book exchange form to make it more specific and user friendly.

Checklist:

  • [x ] I have taken help from some online resources.

  • [x ] My code follows the style guidelines of this project.

  • [ x] I have performed a self-review of my own code.

  • [ x] I have commented my code, particularly in hard-to-understand areas.

  • [ x] My changes generate no new warnings.

  • [ x] I have tested the changes thoroughly before submitting this pull request.

  • [ x] I have provided relevant issue numbers and screenshots after making the changes.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 5:29pm

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 8ef5759
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/67114968c0aed80008f744e1
😎 Deploy Preview https://deploy-preview-3609--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@avantikasankhe avantikasankhe added documentation Improvements or additions to documentation enhancement New feature or request level3 Advance gssoc-ext This contribution is under GirlScript Summer of Code 2024 Extended Edition! hacktoberfest-accepted GSSOC Ext. is collaborated with Hacktoberfest labels Oct 17, 2024
@abhi03ruchi abhi03ruchi added level2 Intermediate level3 Advance and removed documentation Improvements or additions to documentation level3 Advance level2 Intermediate labels Oct 17, 2024
@abhi03ruchi
Copy link
Collaborator

resolve merge conflicts @Vivisteria11

@Vivisteria11
Copy link
Contributor Author

I am new to the open source process, kindly guide me if I have to perform any more changes .

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Oct 18, 2024

Screenshot 2024-10-18 at 7 31 16 AM Just change the text alignment to left .

will merge the pr then .

@Vivisteria11
Copy link
Contributor Author

When I ran it before making the pull request it was aligned properly. How did it change.
Should I go back and push the changes through git again ??

@sailaja-adapa
Copy link
Collaborator

sailaja-adapa commented Oct 18, 2024

your changes were good but please work with updated branch @Vivisteria11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext This contribution is under GirlScript Summer of Code 2024 Extended Edition! hacktoberfest-accepted GSSOC Ext. is collaborated with Hacktoberfest level3 Advance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Book Exchange hub
4 participants