Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3862:Modified the navbar which includes all navbar items now. #3891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes #3862:Modified the navbar which includes all navbar items now. #3891

wants to merge 2 commits into from
+330 −240

Conversation

Arghya-Chakraborty0812
Copy link
Contributor

Related Issue

None

Fixes: #3862

Description

The navbar in the audio books section did not have all navbar items which were added as requested.

issue.no:#3862

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

New:
Screenshot 2024-10-22 at 11 48 57 PM

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.
    Please can you assign me level 2 for this.

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:20pm

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 3ed7f4e
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/6717ecc3accb8e0008c54d75
😎 Deploy Preview https://deploy-preview-3891--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Oct 23, 2024 •
edited
Loading

Screenshot 2024-10-23 at 5 36 21 AM correct the navbar responsiveness too . Screenshot 2024-10-23 at 5 36 40 AM also keep the navbar design like that in bookListSwap page . contact icon is not visible etc...

@anuragverma108
Copy link
Owner

Screenshot 2024-10-23 at 5 36 21 AM correct the navbar responsiveness too . Screenshot 2024-10-23 at 5 36 40 AM also keep the navbar design like that in bookListSwap page . contact icon is not visible etc...

@Arghya-Chakraborty0812 Are you working on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG:Navbar's alignment can be improved in the Audio books sections
3 participants
@Arghya-Chakraborty0812 @abhi03ruchi @anuragverma108