Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3868: enhance ui for faqs page #3925

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jainaryan04
Copy link
Contributor

Fixes: #3868

Description

change <script> code to ensure than after the user expands a particular faq, the previous answer is hidden

Type of PR

  • UI enhancement

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 4:42pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 9fb9834
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/6719275488617d000701af10
😎 Deploy Preview https://deploy-preview-3925--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhi03ruchi abhi03ruchi added level2 Intermediate gssoc-ext This contribution is under GirlScript Summer of Code 2024 Extended Edition! hacktoberfest-accepted GSSOC Ext. is collaborated with Hacktoberfest labels Oct 23, 2024
@abhi03ruchi
Copy link
Collaborator

there is another faq in books page. this is leading to redundancy .
remove faq section from books page .

@abhi03ruchi abhi03ruchi removed the level2 Intermediate label Oct 23, 2024
@jainaryan04
Copy link
Contributor Author

@abhi03ruchi I have not added faqs
Just added the script code so that only one faq can be expanded at a time.

@abhi03ruchi
Copy link
Collaborator

@abhi03ruchi I have not added faqs Just added the script code so that only one faq can be expanded at a time.

i know that . just chk books page . it also had a faq section . just delete faq section code from there .

@jainaryan04
Copy link
Contributor Author

jainaryan04 commented Oct 23, 2024

@abhi03ruchi I have not added faqs Just added the script code so that only one faq can be expanded at a time.

i know that . just chk books page . it also had a faq section . just delete faq section code from there .

FAQ's are there in these 12 files. Just to confirm, you want me to remove them from all the files other than index.html ?
image

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Oct 23, 2024

just check once the pages , if the faq section is the same on the pages as on the home page( index.html) . delete them.

@jainaryan04
Copy link
Contributor Author

@abhi03ruchi done

@abhi03ruchi abhi03ruchi added the level2 Intermediate label Oct 23, 2024
@abhi03ruchi abhi03ruchi merged commit dfbfe09 into anuragverma108:main Oct 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext This contribution is under GirlScript Summer of Code 2024 Extended Edition! hacktoberfest-accepted GSSOC Ext. is collaborated with Hacktoberfest level2 Intermediate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: enhance ui for faqs page
2 participants