Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Navbar #4049

Closed
wants to merge 1 commit into from
Closed

Conversation

KrishChothani
Copy link

Fixes: #4028

Description

navbar are not align at center in lol.html

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

BEFOR:
image

AFTER ::
image

Checklist:

  • I have made this change from my own.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 3:29pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit 5daff18
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/671d0ab52f61a70008e9a3ea
😎 Deploy Preview https://deploy-preview-4049--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhi03ruchi
Copy link
Collaborator

Screen.Recording.2024-10-26.at.9.03.02.PM.mov

there are still issues in the navbar .
the dropdown of profile avatar , on clicking on more button dropdown doesnt come .

also fix the navbar responsiveness .

@KrishChothani
Copy link
Author

KrishChothani commented Oct 26, 2024

Hey @abhi03ruchi,

I’ve been trying to locate the original navbar in index.html, but it’s been quite a challenge. I spent around 40-50 minutes on it without success due to the CSS and HTML all being in one file. The styles seem to come from multiple sources—style.html, styles.html, and also from various parts of the main file, with some CSS at the beginning and others scattered across components.

Given this setup, it was quite challenging to make adjustments. So for now, I’ve centered the navbar .

Thanks for understanding!

@KrishChothani
Copy link
Author

KrishChothani commented Oct 26, 2024

If you’re happy with these changes, feel free to merge the pull request. Otherwise, you can close it.
If merged: I’m hopeful it’ll provide some valuable improvements!

@KrishChothani
Copy link
Author

Thank you

@abhi03ruchi
Copy link
Collaborator

the navbars are really messed up . different pages have different navbar design . also there is problem in all navbars .
u can work on this issue and resolve all pages navbar , make them uniform .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Not allign Navbar at Center
2 participants