Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation for read later form #4060

Closed
wants to merge 0 commits into from

Conversation

LaibaKhalil61
Copy link
Contributor

Related Issue

Fixes: #4051

Description

There was no validation being done for the author name and book name fields of the read later form. So, I added the validation checks for them.

Type of PR

  • Bug fix

Checklist:

  • I have made this change from my own.
  • I have taken help from some online resources.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers.

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swapreads ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 5:58pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for swapreadsconnect ready!

Name Link
🔨 Latest commit a051297
🔍 Latest deploy log https://app.netlify.com/sites/swapreadsconnect/deploys/671d38dbb1f4ac00085031d4
😎 Deploy Preview https://deploy-preview-4060--swapreadsconnect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LaibaKhalil61
Copy link
Contributor Author

Can someone tell me why the first check is failing ?

@abhi03ruchi
Copy link
Collaborator

abhi03ruchi commented Oct 26, 2024

plz create demo video to showcase ur work. or some screenshots

the form isnt working . plz chk

@LaibaKhalil61
Copy link
Contributor Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:No Form validation for Read Later Form
2 participants