Port the fluent controller #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marshtompsxd , I have read through the changes. But can we handle this after #192 ? |
|
Yes |
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
marshtompsxd
force-pushed
the
verified-fluent-controller
branch
from
f50bf7a
to
db667c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fluent controller, built on top of Anvil, behaves almost the same as the reference unverified fluent controller, except that: (1) The FluentBit configuration is passed to the controller through the CR's fields, and (2) The ported controller uses Role and RoleBinding, instead of Cluster and ClusterRoleBinding, because Anvil doesn't support cluster-scoped resources for now.