Fix bug in updating labels for zookeeper #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
marshtompsxd
changed the title
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
Signed-off-by: Xudong Sun <[email protected]>
marshtompsxd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the zookeeper controller updates the
volume_claim_templatesfield inside the stateful set when the.spec.labelesor.spec.annotationsget updated by the user. However,volume_claim_templatesis immutable (see validation check here: https://github.com/kubernetes/kubernetes/blob/v1.26.3/pkg/apis/apps/validation/validation.go#L171-L192) and such update will deterministically fail, leading to liveness violation. The current validation check logic in the state machine specification needs to be further enhanced so that we can formally reason about such behavior.