Add liveness specification for VReplicaSet controller #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
Signed-off-by: Cody Rivera <[email protected]>
marshtompsxd
reviewed
Jun 7, 2024
| &&& resources.contains_key(key) | ||
| &&& obj.kind == PodView::kind() | ||
| &&& obj.metadata.owner_references_contains(vrs.controller_owner_ref()) | ||
| &&& vrs.spec.selector.matches(obj.metadata.labels.unwrap_or(Map::empty())) |
There was a problem hiding this comment.
@codyjrivera could you add one more line here
&&& obj.metadata.deletion_timestamp.is_None()
Basically we only want to count the pods that are NOT in terminating state.
See the new commit I just added today: 0f03d84
marshtompsxd
reviewed
Jun 7, 2024
|
|
||
| pub open spec fn resource_state_matches(vrs: VReplicaSetView, resources: StoredState) -> bool { | ||
| let pods: Set<ObjectRef> = Set::new(|k: ObjectRef| owned_selector_match_is(vrs, resources, k)); | ||
| &&& pods.finite() |
There was a problem hiding this comment.
Just curious: do we need this line since we have the next line that talks about the length of the pods?
There was a problem hiding this comment.
The file https://github.com/verus-lang/verus/blob/main/source/vstd/set.rs says that len is only meaningful when the set is finite: infinite sets are allowed. Also it can't return anything like -1 to represent an infinite set.
Signed-off-by: Cody Rivera <[email protected]>
marshtompsxd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I state a basic liveness theorem, based on Eventually Stable Reconciliation, for ReplicaSets. To check whether the cluster state matches the spec, I gather up all pods that match the label selector
selectorand are owned by the ReplicaSet into a Verus set. I then check whether the cardinality of that set is equal to thereplicasfield.