-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DROID-3264 Editor | Enhancement | Improved image file layout and features #2045
Merged
Nadezhda-Gurova
merged 4 commits into
main
from
droid-3264-image-file-layout-and-features
Feb 17, 2025
Merged
DROID-3264 Editor | Enhancement | Improved image file layout and features #2045
Nadezhda-Gurova
merged 4 commits into
main
from
droid-3264-image-file-layout-and-features
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...m/anytypeio/anytype/core_ui/features/editor/holders/other/CustomImageResizeTransformation.kt
Outdated
Show resolved
Hide resolved
persistence/src/main/java/com/anytypeio/anytype/persistence/repo/DefaultUserSettingsCache.kt
Outdated
Show resolved
Hide resolved
presentation/src/main/java/com/anytypeio/anytype/presentation/editor/EditorViewModel.kt
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/anytypeio/anytype/presentation/editor/render/DefaultBlockViewRenderer.kt
Outdated
Show resolved
Hide resolved
- Removed unnecessary code in `DefaultUserSettingsCache` and `UserSettingsCache`. - Changed `urlBuilder.original(image)` to `urlBuilder.large(image)` (width = 1080px).
acc3efa
to
84c3526
Compare
...m/anytypeio/anytype/core_ui/features/editor/holders/other/CustomImageResizeTransformation.kt
Outdated
Show resolved
Hide resolved
konstantiniiv
approved these changes
Feb 5, 2025
persistence/src/main/java/com/anytypeio/anytype/persistence/repo/DefaultUserSettingsCache.kt
Outdated
Show resolved
Hide resolved
…yError) in CustomImageResizeTransformation. Add Timber.e logging for better debugging. - Remove legacy constants in DefaultUserSettingsCache.
uburoiubu
approved these changes
Feb 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…stomImageResizeTransformation.
Added logic to display an icon in full-screen mode.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?