Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DROID-3264 Editor | Enhancement | Improved image file layout and features #2045

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

Nadezhda-Gurova
Copy link
Contributor

@Nadezhda-Gurova Nadezhda-Gurova commented Jan 29, 2025

…stomImageResizeTransformation.

Added logic to display an icon in full-screen mode.


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

- Removed unnecessary code in `DefaultUserSettingsCache` and `UserSettingsCache`.
- Changed `urlBuilder.original(image)` to `urlBuilder.large(image)` (width = 1080px).
@Nadezhda-Gurova Nadezhda-Gurova force-pushed the droid-3264-image-file-layout-and-features branch from acc3efa to 84c3526 Compare February 5, 2025 10:27
…yError) in CustomImageResizeTransformation.

 Add Timber.e logging for better debugging.
- Remove legacy constants in DefaultUserSettingsCache.
@Nadezhda-Gurova Nadezhda-Gurova merged commit 88335a1 into main Feb 17, 2025
3 checks passed
@Nadezhda-Gurova Nadezhda-Gurova deleted the droid-3264-image-file-layout-and-features branch February 17, 2025 10:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants