Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: needless_lifetimes #4377

Merged

Conversation

brooksprumo
Copy link

Problem

New clippy lints when upgrading to rust 1.84.0.

warning: the following explicit lifetimes could be elided: 'a
  --> sdk/account-info/src/lib.rs:41:6
   |
41 | impl<'a> fmt::Debug for AccountInfo<'a> {
   |      ^^                             ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
41 - impl<'a> fmt::Debug for AccountInfo<'a> {
41 + impl fmt::Debug for AccountInfo<'_> {
   |

Summary of Changes

cargo clippy --fix

Copy link

mergify bot commented Jan 10, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@brooksprumo brooksprumo marked this pull request as ready for review January 10, 2025 03:02
@brooksprumo brooksprumo requested a review from a team as a code owner January 10, 2025 03:02
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@brooksprumo brooksprumo merged commit edb76bd into anza-xyz:master Jan 10, 2025
50 checks passed
@brooksprumo brooksprumo deleted the rust-1.84.0/clippy/needless-lifetimes branch January 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants