make bank_client optional in tps-client #4390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
tps-client-bank-client-optional
branch
2 times, most recently
from
a62b43c to
9b3ec79
Compare
kevinheavey
force-pushed
the
tps-client-bank-client-optional
branch
from
9b3ec79 to
84662df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The tps-client crate brings in really heavy dependencies (solana-runtime) in bank_client.rs. Most usage of tps-client doesn't need this, in particular solana-cli which will have way lighter deps when this gets merged
Summary of Changes
solana_tps_client::bank_clientbehind a feature gate. This can't be moved to a separate crate because you run into orphan rule problems