v2.1: Update metrics & ema before breaking the connection loop (backport of #4414) #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Update metrics and ema before breaking connection loop (cherry picked from commit 83919b8)
|
This is a regression introduced in v2.1 so the fix is better to be back ported to v2.1 to avoid misbehaving related to the EMA QOS and the confusing metrics. |
t-nelson
approved these changes
Jan 15, 2025
|
@alessandrod you good to give sme approval for this bp? |
alessandrod
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is found that active_streams is none zero even after no connections to the server. This is due to we missed updating metrics in case of connection error when handling chunks.
Summary of Changes
Update metrics and ema before break conn loop.
Fixes #
This is an automatic backport of pull request #4414 done by [Mergify](https://mergify.com).