-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: increase timeout and keep alive #4585
Conversation
Maybe we should different timeout values: stream timeout and idle connection timeout (controlled by the ping) |
We need to investigate why the CI is consistently failing for this PR. I am updating the branch again. |
@0x0ece Looks like this change has made The CI for this change is green but I am guessing the combination of this change with another PR (maybe #4586 ) is causing the test to fail. I have confirmed though reverting this change resolves the issue: https://buildkite.com/anza/agave/builds/17958 This is currently blocking work because the CI is not usable. Can we please revert this and test the change again? |
okay. We can revert it. I will revert immediately @behzadnouri |
Ok, definitely let’s investigate. |
PR for revert: #4637 |
Problem
Quic timeout and keep alive are very low.
When a validator is not leader, it still has thousands of connections open that are not expected to send any data.
Because keep alive is 1s, each client sends a quic ping every second, which is a lot of unnecessary traffic.
Summary of Changes
Increased timeout to 60s and keep alive to 45s.