Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add LeaderSchedule trait #4973

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

refactor: add LeaderSchedule trait #4973

wants to merge 3 commits into from

Conversation

jstarry
Copy link

@jstarry jstarry commented Feb 13, 2025

Problem

Need to add another type of leader schedule introduced by SIMD-0180

Summary of Changes

  • New leader schedule trait named LeaderScheduleVariant
  • Use LeaderSchedule as type alias for Box<dyn LeaderScheduleVariant>
  • Rename some things to make the new trait easier to reason about

Fixes #

@jstarry jstarry mentioned this pull request Feb 13, 2025
Open
@jstarry jstarry requested a review from t-nelson February 13, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-nelson t-nelson Awaiting requested review from t-nelson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jstarry