window svc channels struct #4977
Merged
+126
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steviez
reviewed
Feb 14, 2025
core/src/repair/repair_service.rs
Outdated
| @@ -433,12 +466,9 @@ impl RepairService { | |||
| &blockstore, | |||
| &exit, | |||
| &repair_socket, | |||
| &repair_request_quic_sender, | |||
| &repair_service_channels.repair_channels, | |||
There was a problem hiding this comment.
nit: It looks like the caller takes an owned RepairServiceChannels.
- For
Self::run(), we are passing a reference - For
AncestorHashesService::new(), we are passing the owned channels
For the sake of "symmetry", I think it'd be nice for these to match. I think you could pass owned here as well, since Rust can de-structure the struct implicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We pass around a ton of channels from TVU --> Window Service --> Repair & Ancestor Hashes. It makes the code hard to read and also exceeds the recommended params per function in several spots.
Additionally, this will make it easier to add some sub-structs to repair service to make it more digestible (next on my list).
Summary of Changes
No behavioral change expected. Three main things were done:
#[allow(clippy::too_many_arguments)]