v2.2: txview: run status and age checks on incoming transactions (backport of #4506) #4978
+261
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit 54da9b2)
apfitzge
force-pushed
the
mergify/bp/v2.2/pr-4506
branch
from
2435504 to
db41cc9
Compare
jstarry
approved these changes
Feb 14, 2025
t-nelson
approved these changes
Feb 14, 2025
Comment on lines
-87
to
+94
| /// Pushes a transaction id into the priority queue. If the queue is full, the lowest priority | ||
| /// transaction will be dropped (removed from the queue and map). | ||
| /// Returns `true` if a packet was dropped due to capacity limits. | ||
| fn push_id_into_queue(&mut self, priority_id: TransactionPriorityId) -> bool; | ||
| /// Pushes transaction ids into the priority queue. If the queue if full, | ||
| /// the lowest priority transactions will be dropped (removed from the | ||
| /// queue and map) **after** all ids have been pushed. | ||
| /// To avoid allocating, the caller should not push more than | ||
| /// [`EXTRA_CAPACITY`] ids in a call. | ||
| /// Returns the number of dropped transactions. | ||
| fn push_ids_into_queue( | ||
| &mut self, | ||
| priority_ids: impl Iterator<Item = TransactionPriorityId>, | ||
| ) -> usize; |
There was a problem hiding this comment.
i think we could've got away without some of this refactor stuff for the bp-targeted changes
There was a problem hiding this comment.
This was necessary, lots of context in the original pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
viewtransaction parsing option in banking stage does not run status/age checks before inserting transactions into the bufferSummary of Changes
Fixes #
This is an automatic backport of pull request #4506 done by [Mergify](https://mergify.com).