Simplify and Refactor pre_lock_filter #4980
Open
+34
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pre_lock_filter
has been unused so farSummary of Changes
pre_lock_filter
takes in transaction statepre_lock_filter
returns aPreLockFilterAction
PreLockFilterAction
currently only supports simple pass-throughFuture Plans
PreLockFilterAction::Skip
which allows tx to be skipped, but not removedpre_lock_filter
will use the current bank slot to compare against a (soon to be introduced) latest retry slot to avoid retrying transactions too oftenFixes #