Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to handle other oAuth2 servers, e.g. Google #13

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Add options to handle other oAuth2 servers, e.g. Google #13

merged 7 commits into from
Sep 12, 2023

Conversation

pulzarraider
Copy link
Contributor

@pulzarraider pulzarraider commented Sep 5, 2023 •
edited
Loading

This PR contains these changes:

  • allow to specify empty domain for cookies to create the cookies for just one current domain,
  • authenticate user by e-mail address instead of SSO ID,
  • accept opaque access tokens that are not jwt (for Google oAuth),
  • store access token after first request fetched by code,
  • allow to specify scope delimiter (some oAuth servers prefer space instead of comma),
  • add test for DI configuration.

Possible BC break:

  • added method findOneBySsoEmail in src/Contracts/OAuth2AuthUserRepositoryInterface.php

@pulzarraider pulzarraider changed the title [WIP] Add options to handle other oAuth2 clients, e.g. Google oAuth2 [WIP] Add options to handle other oAuth2 clients, e.g. Google Sep 5, 2023
@pulzarraider pulzarraider changed the title [WIP] Add options to handle other oAuth2 clients, e.g. Google [WIP] Add options to handle other oAuth2 servers, e.g. Google Sep 5, 2023
@pulzarraider pulzarraider changed the title [WIP] Add options to handle other oAuth2 servers, e.g. Google Add options to handle other oAuth2 servers, e.g. Google Sep 11, 2023
@marforon marforon merged commit 50bea95 into main Sep 12, 2023
2 checks passed
@marforon marforon deleted the empty_domain branch September 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marforon marforon marforon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pulzarraider @marforon