[amqphandler] Don't truncate debug logs #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlohvynenko
force-pushed
the
feature_configure_log_trim
branch
4 times, most recently
from
2c702bb
to
26df9cf
Compare
al1img
reviewed
Sep 19, 2024
amqphandler/amqphandler.go
Outdated
| @@ -60,6 +60,8 @@ const ( | |||
| type AmqpHandler struct { //nolint:stylecheck | |||
| sync.Mutex | |||
|
|
|||
| disableLogsTrim bool | |||
There was a problem hiding this comment.
Don't see why we need to have it configurable. Let's just remove log trimming at all.
There was a problem hiding this comment.
JIRA task: https://jiraeu.epam.com/browse/EPMPAOS-5351
Title: [AOS Core] Add the ability not to truncate the unit's messages to the cloud.
So the task is to add an ability to not truncate logs
There was a problem hiding this comment.
Agreed to not truncate logs at all.
Updated PR.
al1img
reviewed
Sep 19, 2024
mlohvynenko
force-pushed
the
feature_configure_log_trim
branch
2 times, most recently
from
9e24c01
to
ba2aa6a
Compare
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
mlohvynenko
force-pushed
the
feature_configure_log_trim
branch
from
ba2aa6a
to
8affbff
Compare
|
mlohvynenko
changed the title
al1img
approved these changes
Oct 2, 2024
mykola-kobets-epam
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.