Renew cert fix #173
Open
Renew cert fix #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
2 times, most recently
from
e8d042b
to
9a84c96
Compare
Signed-off-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
9a84c96
to
694b9b6
Compare
|
al1img
reviewed
Oct 21, 2024
| } | ||
|
|
||
| if err := controller.startGRPCServer(); err != nil { | ||
| log.WithField("err", err).Error("SMController failed to start GRPC server") |
| @@ -29,6 +29,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "golang.org/x/exp/slices" | |||
There was a problem hiding this comment.
No need to duplicate module name in commit message.
| enterPrefix + stateIdle: umCtrl.processIdleState, | ||
| enterPrefix + stateReconnecting: umCtrl.processEnterReconnectingState, | ||
| leavePrefix + stateReconnecting: umCtrl.processLeaveReconnectingState, | ||
|
|
| "sync" | ||
| "sync/atomic" |
| // GetNodeInfo returns node info. | ||
| func (client *Client) GetNodeInfo(nodeID string) (nodeInfo cloudprotocol.NodeInfo, err error) { | ||
| client.Lock() |
There was a problem hiding this comment.
grpc calls are thread-safe why this lock is required here and in others API?
| log.WithField("err", err).Error("CMServer failed to start GRPC server") | ||
|
|
||
| server.restartTimer = time.AfterFunc(cmRestartInterval, func() { | ||
| server.restartTimer = nil |
There was a problem hiding this comment.
Should be guarded with mutex.
|
|
||
| eventChannel chan umCtrlInternalMsg | ||
| nodeInfoProvider NodeInfoProvider | ||
| nodeInfoChannel <-chan cloudprotocol.NodeInfo | ||
| stopChannel chan bool | ||
| componentDir string | ||
| certChan <-chan *iamanager.CertInfo |
| eventChannel: make(chan umCtrlInternalMsg), | ||
| nodeInfoProvider: nodeInfoProvider, | ||
| nodeInfoChannel: nodeInfoProvider.SubscribeNodeInfoChange(), | ||
| certChan: make(<-chan *iamanager.CertInfo), |
| if !insecure { | ||
| if ch, err := localClient.SubscribeCertChanged(config.CertStorage); err != nil { | ||
| return nil, aoserrors.Wrap(err) | ||
| } else { |
There was a problem hiding this comment.
No need else after return.
|
|
||
| secureOpt = grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig)) | ||
| func (client *Client) reconnect() { | ||
| if client.disableReconnect.CompareAndSwap(false, true) { |
There was a problem hiding this comment.
It is unclear why disableReconnect is required. Need to discuss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.