[WIP] Renew certificate fix #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
90423b4
to
e514390
Compare
al1img
reviewed
Oct 2, 2024
| ++mNotificationID; | ||
| mLastMessage = message; | ||
| } | ||
| mCV.notify_all(); |
| */ | ||
| void Start() | ||
| { | ||
| mIsRunning = true; |
| */ | ||
| void Close() | ||
| { | ||
| mIsRunning = false; |
| std::atomic_bool mIsRunning = true; | ||
| std::condition_variable_any mCV; | ||
| std::shared_mutex mMutex; | ||
| std::atomic_uint32_t mNotificationID = 0; |
| * Server writer controller handles server writer streams. | ||
| */ | ||
| template <typename T> | ||
| class ServerWriterController { |
There was a problem hiding this comment.
Then it should be name something like StreamWriter
There was a problem hiding this comment.
renamed to StreamWriter
| if (mCV.wait_for(lock, cWaitTimeout, [this, lastNotificationID] { | ||
| return mNotificationID != lastNotificationID && mLastMessage.has_value(); | ||
| })) { | ||
|
|
| // postpone restart so it didn't block ApplyCert | ||
| mCertChangedResult = std::async(std::launch::async, [this]() { | ||
| LOG_INF() << "async in"; | ||
| sleep(1); |
There was a problem hiding this comment.
Looks not so good, especially with sleep 1.
There was a problem hiding this comment.
Probably async grpc server itf might fix the problem with deferred actions with it's OnDone method.
There was a problem hiding this comment.
no. Takes a lot of time to implement. Left std::async
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
3 times, most recently
from
f700cec
to
9446a13
Compare
al1img
reviewed
Oct 4, 2024
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
9446a13
to
ff574f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #83 +/- ##
===========================================
- Coverage 87.61% 86.95% -0.66%
===========================================
Files 43 48 +5
Lines 3092 4699 +1607
Branches 225 407 +182
===========================================
+ Hits 2709 4086 +1377
- Misses 383 613 +230 ☔ View full report in Codecov by Sentry. |
al1img
reviewed
Oct 9, 2024
| if (mCredentialListUpdated) { | ||
| LOG_DBG() << "Credential list updated: closing connection"; | ||
|
|
||
| mRegisterNodeCtx->TryCancel(); |
There was a problem hiding this comment.
And empty line before break
| // postpone restart so it didn't block ApplyCert | ||
| mCertChangedResult = std::async(std::launch::async, [this]() { | ||
| LOG_INF() << "async in"; | ||
| sleep(1); |
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
5 times, most recently
from
b35f86d
to
93e6dff
Compare
Signed-off-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
Signed-off-by: Mykola Kobets <[email protected]>
mykola-kobets-epam
force-pushed
the
renew-cert-fix
branch
from
93e6dff
to
55f2f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.