[resourcemanager] Parse all node config JSON fields #204
Conversation
mlohvynenko
force-pushed
the
feature_parse_all_node_json
branch
21 times, most recently
from
4fb0ac7
to
4757b66
Compare
|
|
||
| for (size_t i = 0; i < inDevices.Size(); ++i) { | ||
| const auto& inDevice = inDevices[i]; | ||
| auto& jsonDevice = jsonNodeConfig.devices[i]; |
There was a problem hiding this comment.
should we check is inDevices.Size() <= len jsonNodeConfig.devices ?
There was a problem hiding this comment.
Didn't get the point.
Do you mean array max size checks? (for json decode into aos it's done via Array::Resize calls, FillAosStruct for example).
For json encode from aos, no check are done. But anyway our structs rely on aos consts, as well as JSON object desriptors that are declared static in this cpp.
BTW, ocispec doesn't check boundaries when aos is converted into JSON as well
| jsonDevice.hostDevicesLen = inDevice.mHostDevices.Size(); | ||
|
|
||
| for (size_t j = 0; j < inDevice.mGroups.Size(); ++j) { | ||
| jsonDevice.groups[j] = inDevice.mGroups[j].CStr(); |
| } | ||
|
|
||
| for (size_t j = 0; j < inDevice.mHostDevices.Size(); ++j) { | ||
| jsonDevice.hostDevices[j] = inDevice.mHostDevices[j].CStr(); |
|
|
||
| for (size_t i = 0; i < inResources.Size(); ++i) { | ||
| const auto& inResource = inResources[i]; | ||
| auto& jsonResource = jsonNodeConfig.resources[i]; |
mlohvynenko
force-pushed
the
feature_parse_all_node_json
branch
4 times, most recently
from
1cc3441
to
166f5bb
Compare
Signed-off-by: Mykhailo Lohvynenko <[email protected]>
mlohvynenko
force-pushed
the
feature_parse_all_node_json
branch
from
166f5bb
to
2cd5e4d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 70.79% 69.47% -1.32%
===========================================
Files 22 25 +3
Lines 1825 2300 +475
Branches 487 580 +93
===========================================
+ Hits 1292 1598 +306
- Misses 258 411 +153
- Partials 275 291 +16 ☔ View full report in Codecov by Sentry. |
No description provided.