Attempt to fix deprecation warnings in SQLA 2.0 #30036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there no API changes to support SQLA 2? |
|
sqla 1.4 & 2.0 should be backward compatible except the code is too old. I saw many work has done in this end. But most probably they forgot to update the limit. so I come up with this to see if anything else is remaining |
|
it seems to be merged but need core reviewers check |
|
From I can tell this only changes the version range. How does it help with deprecation warnings? |
|
part of this already fix here #29205 now have to see what else need to be done to merge this PR |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
stale
auvipy
removed
the
stale
|
I am closing this PR because it does not fix the mentioned issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #28723