Refactor SqlAlchemy Session.execute() to 2.0 style #32857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
from
8591ba4
to
a4ac956
Compare
uranusjr
approved these changes
Jul 26, 2023
uranusjr
changed the title
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
from
a4ac956
to
87900de
Compare
@uranusjr , thanks for noticing. Fixed |
|
Hi @uranusjr ! |
|
Looks good. Moving to draft to prevent accidental merge before we get 2.7 out. |
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
2 times, most recently
from
9fecee2
to
bafd41d
Compare
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
3 times, most recently
from
fa7ec6e
to
20f502c
Compare
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
4 times, most recently
from
98fef37
to
3910890
Compare
…lain text SQL queries
moiseenkov
force-pushed
the
sqla20_refactore_execute_plain_sql_tex_queries
branch
from
3910890
to
6c4010d
Compare
|
2.7.0 is now out! |
|
@uranusjr , thanks for the good news! Can we merge it then? |
|
@jedcunningham , @potiuk , hi, |
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
Session.execute()calls to SqlAlchemy 2.0 style by wrapping plain text SQL queries withtext()function.It eliminates the warning message:
Using plain strings to indicate SQL statements without using the text() construct is deprecated and will be removed in version 2.0. Ensure plain SQL statements are passed using the text() construct. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)SqlAlchemy documentation: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#execute-method-more-strict-execution-options-are-more-prominent
Related issue: #28723