Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit pandas to <2.2 #37748

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Limit pandas to <2.2 #37748

merged 1 commit into from
Feb 27, 2024

Conversation

Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Feb 27, 2024

closes: #37742

In pandas 2.2 minimal version of the sqlalchemy is 2.0, see: https://pandas.pydata.org/docs/whatsnew/v2.2.0.html#increased-minimum-versions-for-dependencies
However Airflow not fully supports it yet: #28723 even if could technically change the limitation in FAB also limit sqlalchemy to < 2.0, so the better solution that we have for now it is limit pandas in core extra and providers


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis
Copy link
Contributor Author

I'm not sure should we also rebuild images and regenerate constraints for 2.8.2 ?

docker run -it --rm apache/airflow:2.8.2 bash

airflow@720faeb56401:/opt/airflow$ pip list | grep pandas
pandas                                   2.2.1
pandas-gbq                               0.21.0

@potiuk
Copy link
Member

potiuk commented Feb 27, 2024

I'm not sure should we also rebuild images and regenerate constraints for 2.8.2 ?

Yes.

@potiuk
Copy link
Member

potiuk commented Feb 27, 2024

I will do i t - pandas is too important to get it broken

@potiuk
Copy link
Member

potiuk commented Feb 27, 2024

Constraints updated, images are being rebuilt in https://github.com/apache/airflow/actions/runs/8068053366

@potiuk potiuk merged commit 9e4bdc9 into apache:main Feb 27, 2024
99 checks passed
@potiuk potiuk added this to the Airflow 2.8.3 milestone Feb 27, 2024
@potiuk
Copy link
Member

potiuk commented Feb 27, 2024

Images are rebuilt (verified it). Announced at dev@ and users@, also marked it for 2.8.3

@potiuk
Copy link
Member

potiuk commented Feb 27, 2024

BTW, @Taragolis - I wonder if we could add a test to detect this issue? I think it might be good to add it for the future - this will also give us more confidence whe they will fix it and we will have to upgrade. WDYT ?

@Taragolis
Copy link
Contributor Author

@potiuk yeah we could have some integration tests for that, e.g. for MySQL and Postgres. Let me create a task for that, just for avoid situation that we discuss and finally forget to do that 🤣

@Taragolis Taragolis deleted the limit-pandas branch February 27, 2024 21:54
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Mar 6, 2024
@ephraimbuddy ephraimbuddy removed this from the Airflow 2.8.3 milestone Mar 7, 2024
potiuk pushed a commit that referenced this pull request Mar 12, 2024
(cherry picked from commit 9e4bdc9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLAlchemy / Pandas incompatibility
5 participants