Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xmlsec version pin #39528

Closed
wants to merge 1 commit into from
Closed

Fix xmlsec version pin #39528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions airflow/providers/amazon/provider.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ dependencies:
- sqlalchemy_redshift>=0.8.6
- asgiref
- PyAthena>=3.0.10
# XML sec 1.3.14 breaks Amazon's authentication with `lxml & xmlsec libxml2 library version mismatch`
# We should investigate if we can upgrade to a newer version of lxml and xmlsec
# Tracked in https://github.com/apache/airflow/issues/39103
- xmlsec<1.3.14
- jmespath

additional-extras:
Expand All @@ -128,6 +124,10 @@ additional-extras:
- name: python3-saml
dependencies:
- python3-saml>=1.16.0
# XML sec 1.3.14 breaks Amazon's authentication with `lxml & xmlsec libxml2 library version mismatch`
# We should investigate if we can upgrade to a newer version of lxml and xmlsec
# Tracked in https://github.com/apache/airflow/issues/39103
- xmlsec<1.3.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will create an extra dependency is it not?
if so then when we want to remove it (as it might not be needed in the future) it will require having a major release for the provider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xmlsec is a dependency of python3-saml, so it's always been there, and likely will always be.

The change 3 weeks ago was just to set an upper bound. This PR just moves it into the python3-saml extra.


devel-dependencies:
- aiobotocore>=2.7.0
Expand Down
3 changes: 1 addition & 2 deletions generated/provider_dependencies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@
"jsonpath_ng>=1.5.3",
"redshift_connector>=2.0.918",
"sqlalchemy_redshift>=0.8.6",
"watchtower>=2.0.1,<4",
"xmlsec<1.3.14"
"watchtower>=2.0.1,<4"
],
"devel-deps": [
"aiobotocore>=2.7.0",
Expand Down