Always use logical date in DAG run header #43148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
jscheffl
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
approved these changes
Oct 18, 2024
bbovenzi
approved these changes
Oct 18, 2024
kaxil
approved these changes
Oct 18, 2024
pierrejeambrun
added
the
legacy ui
uranusjr
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Kaxil Naik <[email protected]>
uranusjr
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 18, 2024
Co-authored-by: Kaxil Naik <[email protected]>
romsharon98
pushed a commit
that referenced
this pull request
Oct 18, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Kaxil Naik <[email protected]>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
Co-authored-by: Kaxil Naik <[email protected]>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Kaxil Naik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #38365, it was mentioned the label really should use logical date, not data interval end. This comment was however not addressed at all before the PR was merged.
While using
dataIntervalEndfixes some of the runs, it actually makes the display wrong for others. The run ID is generated from logical date, which may be data interval start or end, or another value altogether depending on how the DAG is configured (specifically which timetable is used) and how the run is triggered. Using eitherdataIntervalStartordataIntervalEndis wrong.