fix(helm-chart): dags gitsync credentials

[tobimichael96]

closes: #43247

---

This adds a condition to the env vars being added to the gitsync sidecar. The expected keys are in sync with what is documentation here: https://github.com/romsharon98/airflow/blob/main/chart/values.yaml#L2738

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[romsharon98]

Can you add unit test for this?

[tobimichael96]

Can you add unit test for this?

I added them here: 2b70391

[romsharon98]

It was a really quick solution, great one! @tobimichael96

[jedcunningham]

We at least need to add a newsfragment that these will no longer work and it'll use GIT_SYNC_X instead.

[tobimichael96]

I agree. But I have no idea where and how to put that. Feel free to add/suggest something.

[romsharon98]

just a question, what you think about a solution like this

{{- $gitUsernameKey := if (hasKey .Values.dags.gitSync.credentialsSecret "GITSYNC_USERNAME") "GITSYNC_USERNAME" "GIT_SYNC_USERNAME" -}}
key: $gitUsernameKey

[jedcunningham]

Good idea, but it's in the secret, not in values so that won't work :(

@tobimichael96, you can read about how to do a newsfragment over in the contributing docs.

[tobimichael96]

I added the fragment, let me know if that works for you.

[tobimichael96]

Any updates on this here? From my perspective it could be merged.

[romsharon98]

Any updates on this here? From my perspective it could be merged.

Looks good to me.
@jedcunningham

[potiuk]

LGTM, but as discussed it, we should likely bundle it with a number of other backwards-incompatible changes to the helm chart and relase a new MAJOR release then.