Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure 'bucket_name' falls back to default if missing or falsy #43415

Closed

Conversation

ANIR1604
Copy link

This PR ensures that :

  1. Add fallback for bucket_name parameter when missing or empty.
  2. Uses service_config to set default bucket_name if not provided in function arguments.

Closes: #43379
Assigned By: @potiuk

@potiuk
Copy link
Member

potiuk commented Oct 27, 2024

Can you pleas add a unit test covering it ?

@ANIR1604
Copy link
Author

Can you pleas add a unit test covering it ?

Should i create a new file including the unit test code or edit the existing test file?

@potiuk
Copy link
Member

potiuk commented Oct 27, 2024

Can you pleas add a unit test covering it ?

Should i create a new file including the unit test code or edit the existing test file?

Depends what you find easier. Usually modifying/extending/adding files in existing test suite is easier and make more sense - but it's up to your judgment to propose it. How and where to add unit tests is part of the solution to an error.

@ANIR1604
Copy link
Author

Can you pleas add a unit test covering it ?

I had added unit test covering my PR regarding S3 bucket_name.
Screenshot from 2024-10-29 02-57-11

@ANIR1604 ANIR1604 closed this Nov 2, 2024
@ANIR1604 ANIR1604 deleted the fix/s3-bucket-parameter-missing branch November 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpToS3Operator throws exception if s3_bucket parameter is not passed
2 participants