-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct question type for prepare-provider-documentation #43417
Conversation
I think you should remove those HASH file modifications :) |
Looks like they were added by pre-commit while the source for breeze has not been committed :). Making sure that you do not have any modified file and running Just make sure you have no non-added changes in your workspace. |
8a5528e
to
f990ca3
Compare
@potiuk I tried it out, it doesn't generate anything:
Moreover, also tried force pushing the change only, still running into this |
Maybe try to reinstall your pre-commit/breeze - maybe it is still installed with python 3.8 (though it should not change too much) . I cannot push a fixup to your branch, but I have exactly the same hashes as the one that are on the server- somehow the hashes in your version are calcualated differently.. |
Let me try reinstalling, looks to me that it installed an "older" breeze when I was playing around with some really "old" branch! |
ebc7853
to
84c0aa5
Compare
CI is green, merging. |
That could be - at some point in time i added the change that automatically breeze reinstalls if an older version is used - without even asking the user - it just reinstalls itself, but if you had REALLLY old version of breeze that did not have this mechanism, then yeah - hash calculation changed at some point in time so it could be different. |
For the provider doc preparation, the qn that asked to confirm if we have any changes apart from
doc-only
didn't acknowledgeN
option.Corrected the qn function to fix it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.