Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset name uri handling #43774

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Nov 7, 2024

Will close #43958


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:serialization area:webserver Webserver related Issues labels Nov 7, 2024
@Lee-W Lee-W added the AIP-74 Dataset -> Asset label Nov 7, 2024
@Lee-W
Copy link
Member Author

Lee-W commented Nov 11, 2024

TODO

Extend the following test case to include more asset attributes

  • tests/api_fastapi/core_api/routes/ui/test_assets.py
  • tests/dags/test_only_empty_tasks.py
  • tests/dags/test_assets.py
  • tests/api_connexion/endpoints/test_dag_run_endpoint.py
  • tests/api_connexion/schemas/test_dag_schema.py
  • tests/api_connexion/schemas/test_asset_schema.py
  • tests/timetables/test_assets_timetable.py
  • tests/decorators/test_python.py
  • tests/serialization/test_serialized_objects.py
  • tests/serialization/test_dag_serialization.py
  • tests/serialization/test_serde.py
  • tests/io/test_wrapper.py
  • tests/io/test_path.py
  • tests/utils/test_context.py
  • tests/utils/test_json.py
  • tests/models/test_dag.py
  • tests/models/test_taskinstance.py
  • tests/models/test_serialized_dag.py
  • tests/www/views/test_views_asset.py
  • tests/www/views/test_views_grid.py
  • tests/lineage/test_hook.py
  • tests/jobs/test_scheduler_job.py
  • tests/assets/test_asset.py
  • tests/assets/test_manager.py
  • tests/listeners/test_asset_listener.py

@Lee-W Lee-W force-pushed the fix-asset-name-uri-handling branch from 32394ac to 4726cc2 Compare November 11, 2024 06:28
@Lee-W Lee-W self-assigned this Nov 11, 2024
@Lee-W Lee-W force-pushed the fix-asset-name-uri-handling branch from 4726cc2 to 0b6a309 Compare November 11, 2024 11:07
@Lee-W Lee-W force-pushed the fix-asset-name-uri-handling branch 6 times, most recently from a57ed8b to 9f9366d Compare November 14, 2024 07:43
@uranusjr
Copy link
Member

Makes sense to me. Will take another look when this is ready for review.

@Lee-W Lee-W force-pushed the fix-asset-name-uri-handling branch 3 times, most recently from aee8f7b to 5473c2f Compare November 15, 2024 09:14
@Lee-W Lee-W force-pushed the fix-asset-name-uri-handling branch from 5473c2f to 678640e Compare November 15, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-74 Dataset -> Asset area:serialization area:webserver Webserver related Issues
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Newly added attributes "group" and "name" are not correctly serialized and not returned in Asset API
2 participants