Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84 Get Configs / Get Config Value #43841

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

AIP-84 Get Configs / Get Config Value #43841

wants to merge 7 commits into from
+1,423 −18

Conversation

jason810496
Copy link
Contributor

closes: #42745
related: #42370

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 9, 2024
@jscheffl jscheffl added the legacy api Whether legacy API changes should be allowed in PR label Nov 9, 2024
pierrejeambrun
pierrejeambrun reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

A few suggestions but looking good.

airflow/api_fastapi/core_api/routes/public/config.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/config.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/config.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_config.py Show resolved Hide resolved
@jason810496
Copy link
Contributor Author

Hi @pierrejeambrun, here is the update:

Common Accept Header for JSON and Text

I have added HeaderAcceptJsonOrText in common/headers.py, annotated with Mimetype from common/types.py.

I tested it with application/json; charset=utf-8, and for headers including utf-8, we need to use startswith to match the header correctly. Additionally, I included an OpenAPI schema for the Accept header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun left review comments

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate Config related public endpoint to FastAPI
3 participants
@jason810496 @pierrejeambrun @jscheffl