Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI #43874

Merged
merged 29 commits into from
Nov 15, 2024
Merged

AIP-84: Migrating GET Dataset events for DAG runs api to fastAPI #43874

merged 29 commits into from
Nov 15, 2024
+354 −6

Conversation

amoghrajesh
Copy link
Contributor

related #42370

Depends on #43783

Migrating the GET Dataset events for DAG runs to fastAPI

Responses:
Legacy
image

FastAPI
image

Swagger spec
image

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

amoghrajesh and others added 17 commits November 6, 2024 15:22
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 11, 2024
@amoghrajesh
Copy link
Contributor Author

Only the last 3 commits are relevant here

@pierrejeambrun pierrejeambrun added the AIP-84 Modern Rest API label Nov 12, 2024
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Nov 12, 2024 •
edited
Loading

The base branch has been merged, branch needs rebasing.

Also you can add the legacy api tag to allow the CI to build.

pierrejeambrun
pierrejeambrun reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice just a couple of comments.

I'll do a final in depth review when the branch is rebased, it will make the review easier to only have the 'definitive' diff and not also the one from the base branch.

airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
@amoghrajesh amoghrajesh added the legacy api Whether legacy API changes should be allowed in PR label Nov 13, 2024
@amoghrajesh amoghrajesh self-assigned this Nov 13, 2024
@amoghrajesh amoghrajesh mentioned this pull request Nov 13, 2024
Open
1 task
pierrejeambrun
pierrejeambrun reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few suggestions

airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
@amoghrajesh amoghrajesh mentioned this pull request Nov 14, 2024
Merged
pierrejeambrun
pierrejeambrun reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion following the change of convention based on Kaxil's PR that was just merged yesterday.

Otherwise looking good and ready to merge.

Thanks

airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_dag_run.py Show resolved Hide resolved
@amoghrajesh amoghrajesh mentioned this pull request Nov 14, 2024
Open
1 task
@amoghrajesh
Copy link
Contributor Author

OK i got a green CI. Is this one good to merge @pierrejeambrun?

This was referenced Nov 14, 2024
Closed
Open
pierrejeambrun
pierrejeambrun approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebasing, small need and ready to merge.

tests/api_fastapi/core_api/routes/public/test_dag_run.py Outdated Show resolved Hide resolved
@pierrejeambrun
Copy link
Member

Thanks 🎉

@pierrejeambrun pierrejeambrun merged commit 0f14f66 into apache:main Nov 15, 2024
62 checks passed
@pierrejeambrun pierrejeambrun deleted the AIP84-get-dataset-events-dagrun branch November 15, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawwar rawwar rawwar left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

@amoghrajesh amoghrajesh

Labels
AIP-84 Modern Rest API area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
AIP-84 MODERN REST API
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amoghrajesh @pierrejeambrun @rawwar