-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename execution_date to logical_date across codebase #43902
Merged
uranusjr
merged 15 commits into
apache:main
from
astronomer:rename-execution-date-to-logical-date
Nov 15, 2024
Merged
Rename execution_date to logical_date across codebase #43902
uranusjr
merged 15 commits into
apache:main
from
astronomer:rename-execution-date-to-logical-date
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
Airflow's REST/HTTP API
area:CLI
area:Scheduler
including HA (high availability) scheduler
provider:cncf-kubernetes
Kubernetes provider related issues
labels
Nov 11, 2024
4 tasks
sunank200
added
legacy api
Whether legacy API changes should be allowed in PR
legacy ui
Whether legacy UI change should be allowed in PR
labels
Nov 11, 2024
sunank200
force-pushed
the
rename-execution-date-to-logical-date
branch
9 times, most recently
from
November 12, 2024 02:54
ea36b6c
to
65f9b8e
Compare
This needs a news fragment. Rewording the above summary would work fine. See existing files in |
Oh wait, we’re not removing those in this PR yet, so this should not be mentioned at all. |
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
uranusjr
reviewed
Nov 12, 2024
providers/src/airflow/providers/cncf/kubernetes/cli/kubernetes_command.py
Outdated
Show resolved
Hide resolved
uranusjr
reviewed
Nov 14, 2024
uranusjr
reviewed
Nov 14, 2024
sunank200
force-pushed
the
rename-execution-date-to-logical-date
branch
2 times, most recently
from
November 15, 2024 03:01
14a4cff
to
16b27e8
Compare
sunank200
force-pushed
the
rename-execution-date-to-logical-date
branch
from
November 15, 2024 03:01
16b27e8
to
96075b1
Compare
uranusjr
approved these changes
Nov 15, 2024
uranusjr
added
the
airflow3.0:breaking
Candidates for Airflow 3.0 that contain breaking changes
label
Nov 15, 2024
phanikumv
approved these changes
Nov 15, 2024
Lee-W
approved these changes
Nov 15, 2024
hardeybisey
pushed a commit
to hardeybisey/airflow
that referenced
this pull request
Nov 15, 2024
Co-authored-by: Tzu-ping Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
airflow3.0:breaking
Candidates for Airflow 3.0 that contain breaking changes
area:API
Airflow's REST/HTTP API
area:CLI
area:Scheduler
including HA (high availability) scheduler
legacy api
Whether legacy API changes should be allowed in PR
legacy ui
Whether legacy UI change should be allowed in PR
provider:cncf-kubernetes
Kubernetes provider related issues
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR renames
execution_date
tological_date
across the codebase. The shift towardslogical_date
helps move away from the limitations ofexecution_date
, particularly with dynamic DAG runs and cases where multiple runs occur at the same time.Key Changes
execution_date
withlogical_date
including models.execution_date
in the database to allow multiple DAG runs with the same logical time.How
execution_date
andlogical_date
WorkTransitioning from
execution_date
execution_date
.run_id
for human-readable identifiers.data_interval_start
/data_interval_end
for data partitioning in future.id
(auto-incremented) is recommended for ordering DAG runs.execution_date
, switch to usingdata_interval_start
ordata_interval_end
for identifying time ranges.Testing
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.