-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare FAB provider to set next version as major version #43939
base: main
Are you sure you want to change the base?
Conversation
5052745
to
a7adf54
Compare
I need to work on the tests since it seems that setting the state of an already installed provider from ready to non-ready is not that trivial |
I dont think this is right approch. We may still release 1.x versions. For example if we find security risk. I can simply skip its release manually if needed. |
Yeah. Let's keep it ready - agree. It should have |
Sounds good! |
5e14896
to
2e0def4
Compare
The compat tests are failing because Airflow 2.9 and 2.10 tries to install the latest fab provider that is only compatible with Airflow 3. In |
Or should |
I think we will have to simply skip fab provider for Airflow 2.9 and 2.10. That should do the job. It will be installing applicable FAB from PyPI then |
In global_constants.py in Breeze: BASE_PROVIDERS_COMPATIBILITY_CHECKS: list[dict[str, str | list[str]]] = [
{
"python-version": "3.9",
"airflow-version": "2.8.4",
"remove-providers": "cloudant fab edge",
"run-tests": "true",
},
{
"python-version": "3.9",
"airflow-version": "2.9.3",
"remove-providers": "cloudant edge",
"run-tests": "true",
},
{
"python-version": "3.9",
"airflow-version": "2.10.3",
"remove-providers": "cloudant",
"run-tests": "true",
},
] |
2e0def4
to
2a0f052
Compare
Makes sense. Thank you! |
All tests are passing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary block to avoid merge
Lets wait with this after we finish current wave of providers. If we merge this PR we wont be able to make rc2.
After provider wave is finished we can dismiss this block and merge
Prepare the provider to set its next version as major version. I also set the state of the provider as non-ready because we should not release the provider next major version before Airflow 3 release timeframe.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.