-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP 84: Migrate POST ASSET EVENT legacy API to fast API. #43984
Merged
pierrejeambrun
merged 56 commits into
apache:main
from
astronomer:AIP84-create-asset-events
Nov 15, 2024
Merged
AIP 84: Migrate POST ASSET EVENT legacy API to fast API. #43984
pierrejeambrun
merged 56 commits into
apache:main
from
astronomer:AIP84-create-asset-events
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jed Cunningham <[email protected]>
…w into AIP84-get-asset-events
…rflow into AIP84-get-asset-events taking latest
vatsrahul1001
added
the
legacy api
Whether legacy API changes should be allowed in PR
label
Nov 14, 2024
…e-asset-events Merging from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for the PR.
A few suggestions looking good overall :)
2 tasks
1 task
pierrejeambrun
changed the title
AIP 84: Migrate POST ASSET EVENTS legacy API to fast API.
AIP 84: Migrate POST ASSET EVENT legacy API to fast API.
Nov 15, 2024
pierrejeambrun
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit to adjust and we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:API
Airflow's REST/HTTP API
area:UI
Related to UI/UX. For Frontend Developers.
legacy api
Whether legacy API changes should be allowed in PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating the connexion API for POST ASSETS EVENTS to fastAPI.
Depends on #43881
related: #43845
Swagger Specs
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.