Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP 84: Migrate POST ASSET EVENT legacy API to fast API. #43984

Merged
merged 56 commits into from
Nov 15, 2024

Conversation

vatsrahul1001
Copy link
Collaborator

Migrating the connexion API for POST ASSETS EVENTS to fastAPI.

Depends on #43881
related: #43845

Swagger Specs
image
image


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

amoghrajesh and others added 30 commits November 6, 2024 15:22
…rflow into AIP84-get-asset-events

taking latest
@vatsrahul1001 vatsrahul1001 added the legacy api Whether legacy API changes should be allowed in PR label Nov 14, 2024
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review November 14, 2024 09:49
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the PR.

A few suggestions looking good overall :)

airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/assets.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_assets.py Outdated Show resolved Hide resolved
@pierrejeambrun pierrejeambrun changed the title AIP 84: Migrate POST ASSET EVENTS legacy API to fast API. AIP 84: Migrate POST ASSET EVENT legacy API to fast API. Nov 15, 2024
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit to adjust and we can merge.

airflow/api_fastapi/core_api/datamodels/assets.py Outdated Show resolved Hide resolved
@pierrejeambrun pierrejeambrun merged commit fd0a0d2 into apache:main Nov 15, 2024
62 checks passed
@pierrejeambrun pierrejeambrun deleted the AIP84-create-asset-events branch November 15, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants