Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix side effect of bad grpc.Chanel mocking #44029

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix side effect of bad grpc.Chanel mocking #44029

merged 1 commit into from
Nov 14, 2024
+44 −30

Commits on Nov 14, 2024

  1. Fix side effect of bad grpc.Chanel mocking 

    The grpc.Channel has been patched but not relased in the test_grpc.py
and it could have caused other tests failing - when they were run
later in the same interpreter. For example it failed in in apache#44011 in the
apache#44011 (comment)

Patching is now fixed via using fixtures.
    @potiuk
    potiuk committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c957f02 View commit details
    Browse the repository at this point in the history