Give log event a name in a test #44046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly pointless but hey. I didn't want to write log because there's often a log var. I was annoyed that pre-commit was complaining about this so I just noqa'd it. But what Kaxil wants, Kaxil gets ;)
kaxil
approved these changes
Nov 14, 2024
|
|
PR of the month ;) |
potiuk
approved these changes
Nov 15, 2024
kaxil
added
the
changelog:skip
Yeah if this does not win it’s a totally rigged competition |
hardeybisey
pushed a commit
to hardeybisey/airflow
that referenced
this pull request
Nov 15, 2024
This is mostly pointless but hey. I didn't want to write log because there's often a log var. I was annoyed that pre-commit was complaining about this so I just noqa'd it. But what Kaxil wants, Kaxil gets ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly pointless but hey.
I didn't want to write log because there's often a log var. I was annoyed that pre-commit was complaining about this so I just noqa'd it. But what Kaxil wants, Kaxil gets ;)