Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rowcount logging in exasol provider (#44022) #45760

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

Briimbo
Copy link
Contributor

@Briimbo Briimbo commented Jan 17, 2025

Fix logging the rowcount in the exasol provider by actually calling the method
closes: #44022


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Jan 17, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes agree to @eladkal - If you revert the newsfragment it is good to be merged.

Thanks for the fix!

@Briimbo Briimbo force-pushed the 44022_exasol_rowcount branch from 3b7f51c to 4d14b93 Compare January 18, 2025 07:49
@Briimbo
Copy link
Contributor Author

Briimbo commented Jan 18, 2025

Thanks for the feedback, I removed the newsfragment

@jscheffl jscheffl self-requested a review January 18, 2025 08:12
@jscheffl
Copy link
Contributor

Thanks for the feedback, I removed the newsfragment

Pytests reveal... is is not a method but a property. Are you sure your fix is correct?

@Briimbo
Copy link
Contributor Author

Briimbo commented Jan 18, 2025

Yes I am sure it is correct. We use it in our production app and always get a reference to the method in the log, which is identical to what is descibed in the bug report 44022.

Also, if you take a look at the pyexasol implementation of rowcount, you can see that it is actually a method instead of a property. There is a property row_count, but the rowcount method should be used.

I will look into fixing the tests

@Briimbo Briimbo force-pushed the 44022_exasol_rowcount branch from 4d14b93 to 2dfc509 Compare January 18, 2025 09:10
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense - so a mocking issue on the fix. Thanks for adjusting the mocks!

@jscheffl jscheffl merged commit 3e8449f into apache:main Jan 18, 2025
61 checks passed
Copy link

boring-cyborg bot commented Jan 18, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exasol hook logging of rowcount
3 participants