-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rowcount logging in exasol provider (#44022) #45760
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agree to @eladkal - If you revert the newsfragment it is good to be merged.
Thanks for the fix!
3b7f51c
to
4d14b93
Compare
Thanks for the feedback, I removed the newsfragment |
Pytests reveal... is is not a method but a property. Are you sure your fix is correct? |
Yes I am sure it is correct. We use it in our production app and always get a reference to the method in the log, which is identical to what is descibed in the bug report 44022. Also, if you take a look at the pyexasol implementation of rowcount, you can see that it is actually a method instead of a property. There is a property I will look into fixing the tests |
4d14b93
to
2dfc509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes sense - so a mocking issue on the fix. Thanks for adjusting the mocks!
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Fix logging the rowcount in the exasol provider by actually calling the method
closes: #44022
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.