Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DagRun conf errors in FAB's list view #45763

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 17, 2025

Before:

image

After:

image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Before:

```
root@6080aa107d9c:/opt/airflow# airflow webserver
  ____________       _____________
 ____    |__( )_________  __/__  /________      __
____  /| |_  /__  ___/_  /_ __  /_  __ \_ | /| / /
___  ___ |  / _  /   _  __/ _  / / /_/ /_ |/ |/ /
 _/_/  |_/_/  /_/    /_/    /_/  \____/____/|__/
Running the Gunicorn Server with:
Workers: 4 sync
Host: 0.0.0.0:8080
Timeout: 120
Logfiles: - -
Access Logformat:
=================================================================

[2025-01-17T21:39:45.349+0000] {override.py:949} WARNING - No user yet created, use flask fab command to do it.
[2025-01-17T21:39:45.637+0000] {forms.py:107} ERROR - Column conf Type not supported
[2025-01-17T21:39:45.637+0000] {forms.py:107} ERROR - Column conf Type not supported
^C[2025-01-17T21:39:46.187+0000] {webserver_command.py:430} INFO - Received signal: 2. Closing gunicorn.
```

After:
```
root@6080aa107d9c:/opt/airflow# airflow webserver
  ____________       _____________
 ____    |__( )_________  __/__  /________      __
____  /| |_  /__  ___/_  /_ __  /_  __ \_ | /| / /
___  ___ |  / _  /   _  __/ _  / / /_/ /_ |/ |/ /
 _/_/  |_/_/  /_/    /_/    /_/  \____/____/|__/
Running the Gunicorn Server with:
Workers: 4 sync
Host: 0.0.0.0:8080
Timeout: 120
Logfiles: - -
Access Logformat:
=================================================================

[2025-01-17T21:40:16.365+0000] {override.py:949} WARNING - No user yet created, use flask fab command to do it.
[2025-01-17 21:40:18 +0000] [18864] [INFO] Starting gunicorn 23.0.0
[2025-01-17 21:40:29 +0000] [18864] [INFO] Listening at: http://0.0.0.0:8080 (18864)
[2025-01-17 21:40:29 +0000] [18864] [INFO] Using worker: sync
```
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 17, 2025
@kaxil kaxil requested a review from jedcunningham January 17, 2025 21:44
@jedcunningham jedcunningham merged commit 3af9ddd into apache:main Jan 17, 2025
46 checks passed
@jedcunningham jedcunningham deleted the conf-value-error branch January 17, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants