Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-1737] 0.3.x fix the tasks of ScheduledExecutorService that halts when an exception or error is thrown #1743

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

resolve #1737 in 0.3.x

Brief change log

  • add try-catch for scheduleWithFixedDelay

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@wangtaohz wangtaohz requested a review from Aireed July 26, 2023 11:02
Copy link
Contributor

@Aireed Aireed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aireed Aireed merged commit 9cfcb24 into apache:0.3.x Jul 26, 2023
1 check passed
@wangtaohz wangtaohz deleted the 0.3.x-fix-1737 branch July 26, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants