Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix the value of authType is always null #2964

Closed
wants to merge 1 commit into from

Conversation

xleoken
Copy link
Member

@xleoken xleoken commented Jun 25, 2024

Why are the changes needed?

As title.

Brief change log

We should use CatalogMeta#getAuthConfigs instead of CatalogMeta#getCatalogProperties.

CatalogMeta(catalogName:test, catalogType:custom, storageConfigs:{storage.type=S3}, authConfigs:{auth.type=ak/sk}, catalogProperties:{s3.access-key-id=c, s3.secret-access-key=b, table.self-optimizing.group=test, s3.endpoint=a, catalog-impl=org.apache.iceberg.rest.ABCD, table-formats=ICEBERG, client.region=a})

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the work! @xleoken

@zhoujinsong
Copy link
Contributor

Hi, can you help me confirm the impact of this issue? This will determine whether the fix needs to be included in version 0.7.0.

@xleoken
Copy link
Member Author

xleoken commented Jun 25, 2024

Hi, can you help me confirm the impact of this issue? This will determine whether the fix needs to be included in version 0.7.0.

ok, let's wait the ci first.

@xleoken xleoken marked this pull request as draft June 25, 2024 12:11
@xleoken
Copy link
Member Author

xleoken commented Jun 26, 2024

hi @zhoujinsong, there is the same logic here, we just need to keep one of them, what do you think?

image

@xleoken
Copy link
Member Author

xleoken commented Jun 27, 2024

Thanks for reviewing @zhoujinsong. Close this issue due to #2972

@xleoken xleoken closed this Jun 27, 2024
@xleoken xleoken deleted the authType branch June 28, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants