Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Unify the common parts of the dashboard API and the open API #3014

Merged
merged 5 commits into from
Jul 11, 2024
Merged

[Improvement] Unify the common parts of the dashboard API and the open API #3014

merged 5 commits into from
Jul 11, 2024

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

As titled.

Brief change log

  • Unify the common parts of the dashboard API and the open API.
  • Improve some logging messages.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Jul 9, 2024
czy006
czy006 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@czy006 czy006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit f1fbfa1 into apache:master Jul 11, 2024
4 checks passed
@zhoujinsong zhoujinsong deleted the improve-dashboard-routers branch July 11, 2024 08:52
@zhoujinsong zhoujinsong mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czy006 czy006 czy006 approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhoujinsong @czy006