Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3015]terminal can't create iceberg table when using unified catalog #3016

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Aireed
Copy link
Contributor

@Aireed Aireed commented Jul 9, 2024

Why are the changes needed?

Close #3015

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Jul 9, 2024
@Aireed
Copy link
Contributor Author

Aireed commented Jul 9, 2024

cc @baiyangtx 。 PTAL

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@zhoujinsong zhoujinsong merged commit 72380a4 into apache:master Jul 10, 2024
4 checks passed
@Aireed Aireed deleted the issue_3015 branch September 6, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: terminal can't create iceberg table when using unified catalog
3 participants