Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3029] Fix table record calculating with empty table #3030

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

Close #3029 .

Brief change log

  • Return 0 records when the table has no snapshot.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@github-actions github-actions bot added the module:ams-server Ams server module label Jul 12, 2024
Copy link
Contributor

@XBaith XBaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit 9b3318d into apache:master Jul 12, 2024
4 checks passed
@zhoujinsong zhoujinsong deleted the fix-empty-table-detail branch July 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Successfully created a table on S3 through the terminal, but the query on the Tables page reported 500
2 participants