[AMORO-405]: Added overview page in AMS dashboard #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into overview_page_fe
MarigWeizhi
changed the title
# Conflicts: # amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/optimizing/OptimizerGroupMetrics.java
github-actions
bot
added
the
type:docs
# Conflicts: # amoro-ams/amoro-ams-server/src/main/java/org/apache/amoro/server/table/TableSummaryMetrics.java # amoro-web/src/services/overview.service.ts
# Conflicts: # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewCache.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewMetricsReporter.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/controller/OverviewController.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/model/OverviewDataSizeItem.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/model/OverviewResourceUsageItem.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/model/OverviewSummary.java # amoro-ams/src/main/java/org/apache/amoro/server/dashboard/model/OverviewTopTableItem.java # amoro-ams/src/main/resources/META-INF/services/org.apache.amoro.metrics.MetricReporter # amoro-ams/src/test/java/org/apache/amoro/server/dashboard/TestOverviewCache.java
# Conflicts: # amoro-web/src/language/en.ts # amoro-web/src/language/zh.ts
MarigWeizhi
changed the title
zhoujinsong
reviewed
Sep 11, 2024
There was a problem hiding this comment.
@MarigWeizhi Thanks for the contribution.
This PR looks good in general except some minor issues may need to be improved.
BTW, I have some suggestions about the ams-web changes:
- Remove introduce page
- Display overview page by default.
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/DashboardServer.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewCache.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewCache.java
Outdated
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewCache.java
Outdated
Show resolved
Hide resolved
zhoujinsong
reviewed
Sep 11, 2024
amoro-ams/src/main/java/org/apache/amoro/server/dashboard/OverviewCache.java
Outdated
Show resolved
Hide resolved
fixed |
zhoujinsong
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #405
Brief change log
Components cards
Config
You can configure the cache refresh interval and maximum count of cache records in
conf/plugins/metric-reporters.yamlHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation