[Amoro-3237] Generalize TaskRuntime to support more task types #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majin1102
changed the title
majin1102
changed the title
majin1102
force-pushed
the
task-refactor
branch
from
f18de4d
to
92de9dd
Compare
majin1102
requested review from
zhoujinsong,
zhongqishang and
baiyangtx
and removed request for
zhoujinsong and
zhongqishang
baiyangtx
reviewed
Oct 9, 2024
| public ExecutingStageTask( | ||
| long tableId, String partition, RewriteFilesInput input, Map<String, String> properties) { | ||
| super(tableId, input, properties); | ||
| this.partition = partition; |
There was a problem hiding this comment.
Persistence is required, otherwise information will be lost after recover.
There was a problem hiding this comment.
Persistence logic has not been modified.
Please check it in TaskRuntime.persistTaskRuntime()
zhoujinsong
reviewed
Oct 11, 2024
There was a problem hiding this comment.
@majin1102 Thanks for the work!
This is a good start to support more task types.
I left some small suggestions, PTAL.
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/TaskRuntime.java
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/optimizing/StagedTaskDescriptor.java
Show resolved
Hide resolved
added 6 commits
October 11, 2024 16:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3237.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation